[documentation] Clarify getAccounts and new Account #2124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
#1154 pointed out that it's not clear what
web3.eth.getAccounts
is doing. This PR tells howweb3.eth.personal.newAccount
andweb3.eth.getAccounts
work together and which RPC methods they call. It describes how it's different thanweb3.eth.accounts.create()
.The missing documentation for
web3.eth.personal.getAccounts
was added.Related bounty: #2081
Does it work?
This how it's rendered locally. It will look a little different when it gets deployed.
change
web3.eth.getAccounts()
create
web3.eth.personal.getAccounts()
change
web3.eth.personal.newAccount()
change
web3.eth.accounts.create()