Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Clarify getAccounts and new Account #2124

Merged
merged 4 commits into from
Dec 17, 2018
Merged

[documentation] Clarify getAccounts and new Account #2124

merged 4 commits into from
Dec 17, 2018

Conversation

tcrowe
Copy link

@tcrowe tcrowe commented Dec 14, 2018

What does it do?

#1154 pointed out that it's not clear what web3.eth.getAccounts is doing. This PR tells how web3.eth.personal.newAccount and web3.eth.getAccounts work together and which RPC methods they call. It describes how it's different than web3.eth.accounts.create().

The missing documentation for web3.eth.personal.getAccounts was added.

Related bounty: #2081

Does it work?

This how it's rendered locally. It will look a little different when it gets deployed.

change web3.eth.getAccounts()

screen shot 2018-12-14 at 1 33 33 pm


create web3.eth.personal.getAccounts()

screen shot 2018-12-14 at 1 38 25 pm


change web3.eth.personal.newAccount()

screen shot 2018-12-14 at 1 38 36 pm


change web3.eth.accounts.create()

screen shot 2018-12-14 at 1 38 50 pm

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 3223b0f on tcrowe:docs-getaccounts-1154 into 1d9f6c0 on ethereum:1.0.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 3223b0f on tcrowe:docs-getaccounts-1154 into 1d9f6c0 on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 3223b0f on tcrowe:docs-getaccounts-1154 into 1d9f6c0 on ethereum:1.0.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 3223b0f on tcrowe:docs-getaccounts-1154 into 1d9f6c0 on ethereum:1.0.

@nivida
Copy link
Contributor

nivida commented Dec 17, 2018

Wow great! Thanks, @tcrowe!

@nivida nivida self-requested a review December 17, 2018 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants