Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] Fixing fromWei and toWei #2145

Merged
merged 1 commit into from
Dec 27, 2018
Merged

[documentation] Fixing fromWei and toWei #2145

merged 1 commit into from
Dec 27, 2018

Conversation

nanspro
Copy link

@nanspro nanspro commented Dec 24, 2018

As #1874 pointed out
web3.utils.toWei and web3.utils.fromWei 's docs are poorly written and input parameters, return types are given are incorrect.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 0b89309 on nanspro:issue-1874 into 4b20fc7 on ethereum:1.0.

@nivida nivida merged commit 1bbfc5a into web3:1.0 Dec 27, 2018
@nanspro nanspro mentioned this pull request Dec 29, 2018
Closed
4 tasks
@cgewecke cgewecke mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanspro @coveralls @nivida