Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Changing parameters of methods.myMethod.call() #2148

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

nanspro
Copy link

@nanspro nanspro commented Dec 24, 2018

Right now as #1287 stated,
blockNumber is not defined in the docs and methods.myMethod.call() function's input parameters are poorly written.
This PR fixes #1287 !!

@coveralls
Copy link

coveralls commented Dec 24, 2018

Coverage Status

Coverage remained the same at 83.071% when pulling 8766f1e on nanspro:issue_1287 into 1bbfc5a on ethereum:1.0.

@nivida nivida added the Documentation Relates to project wiki or documentation label Dec 27, 2018
@nanspro
Copy link
Author

nanspro commented Dec 29, 2018

@nivida could you review and tell me if there is any issue with changes proposed.

Copy link

@einaralex einaralex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivida
Copy link
Contributor

nivida commented Jan 21, 2019

Thanks for fixing this documentation issue!

@nivida nivida merged commit 33bf0f5 into web3:1.0 Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web3 1.0: Specifying block number in contract method calls.
4 participants