Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates OutputTransactionFormatter to handle null receipts #2264

Closed
wants to merge 1 commit into from

Conversation

akeem
Copy link

@akeem akeem commented Jan 29, 2019

As a continuation of the work introduced in #2248, this change ensures that the formatter can now accommodate the potential null receipt being passed to it.

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on the live network.

As a continuation of the work introduced in web3#2248, this change ensures that the formatter can now accommodate the potentiall null receipt being passed to it.
@akeem
Copy link
Author

akeem commented Jan 29, 2019

disregard, closing as irrelevant

@akeem akeem closed this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant