Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add input to transaction type #2474

Closed
wants to merge 1 commit into from

Conversation

bradennapier
Copy link

@bradennapier bradennapier commented Mar 8, 2019

Description

Adds input to Transaction type for the Typescript types.

Fixes #2473

Type of change

  • Bug fix

Checklist:

  • [x ] I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.529% when pulling 9f4f854 on bradennapier:types/add-input-to-tx into 970d837 on ethereum:1.0.

@bradennapier
Copy link
Author

bradennapier commented Mar 8, 2019

Can not tell you why your CI is failing - tests definitely work fine.

lerna success run Ran npm script 'test' in packages:
lerna success - web3-core-helpers
lerna success - web3-core-method
lerna success - web3-core-promievent
lerna success - web3-core-subscriptions
lerna success - web3-core
lerna success - web3-eth-abi
lerna success - web3-eth-accounts
lerna success - web3-eth-contract
lerna success - web3-eth-ens
lerna success - web3-eth-iban
lerna success - web3-eth-personal
lerna success - web3-eth
lerna success - web3-net
lerna success - web3-providers
lerna success - web3-shh
lerna success - web3-utils
lerna success - web3

Copy link
Contributor

@joshstevens19 joshstevens19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot - thanks for the PR @nivida can you merge when you get a second.

@joshstevens19 joshstevens19 added the Types Incorrect or missing types label Mar 8, 2019
@nivida
Copy link
Contributor

nivida commented Mar 8, 2019

@joshstevens19 Will check the PR #2479 and probably close this one.

@bradennapier
Copy link
Author

nice, yeah this is exactly what i wanted to do actually but i didn't have the time to look into all the potential side effects! very nice! I will close this

@bradennapier bradennapier deleted the types/add-input-to-tx branch March 8, 2019 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Types Incorrect or missing types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Transaction missing input
4 participants