Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MethodFactory fixed and test added #2566

Merged
merged 2 commits into from
Mar 25, 2019
Merged

MethodFactory fixed and test added #2566

merged 2 commits into from
Mar 25, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Mar 25, 2019

Description

Fixes #2558

Type of change

  • Bug fix

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels Mar 25, 2019
@nivida nivida removed the In Progress Currently being worked on label Mar 25, 2019
@nivida nivida merged commit 9d4bfb7 into 1.0 Mar 25, 2019
@nivida nivida deleted the issue/2558 branch March 25, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this.getGasPrice is not a function; GasPriceMethod vs GetGasPriceMethod
1 participant