Add "empty data" check to AbiCoder::decodeLog #2686
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR address an issue discussed in (and related to) #2582.
AbiCoder::decodeLog
is not performing the same "empty data" check that PR #2549 added toEventLogDecoder::decode
.I wasn't able to get the tests to run properly on my machine... not sure what I'm doing wrong there. But this is such a minor change I'm not sure it's necessary? I was able to test this locally with Ganache and it works just fine.
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct