-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapts checksum functionality to RSKIP60 and EIP55 #2727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR!
Could you update the related documentation and the types for both methods?
@nivida thanks! I'm working on your reviews. |
@alepc253 I would like to write that down in a new issue and to implement it later as an enhancement. The question will be if Web3 should automatically load the |
Description
This PR adapts checksum functionality to RSKIP-60 compatible with EIP-55.
The implementation considers sending optional
chainId
parameter to checksum methods (withchainId = null
as default, Ethereum checksum is applied).Benefit
Type of change
Checklist:
npm run test
in the root folder with success and extended the tests if necessary.npm run build
in the root folder and tested it in the browser and with node.npm run dtslint
in the root folder and tested that all my types are correct