Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction.to can be null #2753

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Transaction.to can be null #2753

merged 3 commits into from
Apr 30, 2019

Conversation

alexkvak
Copy link

According to docs
to - String: Address of the receiver. null when its a contract creation transaction.

@coveralls
Copy link

coveralls commented Apr 29, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.941% when pulling d93db68 on alexkvak:patch-1 into 54325df on ethereum:1.0.

princesinha19
princesinha19 reviewed Apr 29, 2019
View reviewed changes
Copy link
Contributor

@princesinha19 princesinha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't make it as optional. RPC returns null if it's a contract creation so, we shouldn't make it as an optional parameter. In all case to parameter will exist.

@alexkvak alexkvak changed the title Transaction.to is optional Transaction.to can be null Apr 29, 2019
@alexkvak
Copy link
Author

@princesinha19 agree, fixed

joshstevens19
joshstevens19 approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@joshstevens19 joshstevens19 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alexkvak 👍 @nivida can you merge.

princesinha19
princesinha19 approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@princesinha19 princesinha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alexkvak.

@nivida nivida added the Types Incorrect or missing types label Apr 30, 2019
@nivida nivida merged commit ace363d into web3:1.0 Apr 30, 2019
@joshstevens19 joshstevens19 mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nivida nivida nivida approved these changes

@joshstevens19 joshstevens19 joshstevens19 approved these changes

@princesinha19 princesinha19 princesinha19 approved these changes

Assignees
No one assigned
Labels
Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexkvak @coveralls @nivida @joshstevens19 @princesinha19