bugfix: issue 1351 Quourm block timestamp bigNumber conversion issue #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove duplicate line (#1086) (#1098) * Align text for unitMap (#1127) * fixing compiler errors (#1174) * Added web3j-scala to the list of Other Implementations (#1206) * Extends HttpProvider with custom http headers (#1228) * extend HttpProvider with custom http headers * reset formatting * reset formatting * reset formatting * fix null object * fix null object * Adds checksum isAddress() test cases (#1224) * fixed tests * build files
might official web3.py repo is ethereum/web3.py
* fix(allevents): update decode logic to handle no topics * add tests
fix typos in example
Add web3.php link.
* always use fromUtf8 in toHex * add korean test case * treat 0 as 00 instead of end of string * update test case for utf8 * chinese and korean utf8 cases
Add HTML to <!DOCTYPE> so web3 will be populated in browser.
As there another incomplete PHP Library mentioned here I would be happy to add mine too.
nivida
suggested changes
May 2, 2019
princesinha19
suggested changes
May 2, 2019
packages/web3-core-helpers/tests/src/Formatters/OutputBlockFormatterTest.js
Show resolved
Hide resolved
packages/web3-core-helpers/tests/src/Formatters/OutputBlockFormatterTest.js
Show resolved
Hide resolved
princesinha19
suggested changes
May 2, 2019
There was a problem hiding this comment.
@ThomasRalee, Can you please update the test accordingly so, that we could achieve 100% coverage. Btw thanks for this PR.
Merge Updates
Use BN Object to determine if Block's timestamp format
|
@nivida can I please have some feedback? Would be really awesome if this can be merged |
|
Closed because of this PR: #2791 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1215
Replica of PR #2144 by @dmytronasyrov with conflicts resolved