Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to export isBigNumber #2836

Merged
merged 1 commit into from
May 23, 2019
Merged

fix to export isBigNumber #2836

merged 1 commit into from
May 23, 2019

Conversation

chaitanyapotti
Copy link
Contributor

Description

Please include a summary of the change.
Added an export for isBigNumber so that it is available as

import { isBigNumber } from 'web3-utils'

Fixes the following issue

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.949% when pulling 81b5033 on chaitanyapotti:1.0 into dc63f75 on ethereum:1.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.949% when pulling 81b5033 on chaitanyapotti:1.0 into dc63f75 on ethereum:1.0.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on labels May 23, 2019
@nivida nivida removed the In Progress Currently being worked on label May 23, 2019
@nivida nivida merged commit 08388f4 into web3:1.0 May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants