Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U Update the document of sendSignedTransaction. #2914

Merged
merged 4 commits into from
Aug 2, 2019
Merged

U Update the document of sendSignedTransaction. #2914

merged 4 commits into from
Aug 2, 2019

Conversation

Skyge
Copy link
Contributor

@Skyge Skyge commented Jun 27, 2019

Fix #2915
Because the package ethereumjs-tx has upgraded to the version 2.0.0, and it make some changes, so we need to make corresponding changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling b210597 on Skyge:1.x into 7655fe8 on ethereum:1.x.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling b210597 on Skyge:1.x into 7655fe8 on ethereum:1.x.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling b210597 on Skyge:1.x into 7655fe8 on ethereum:1.x.

@coveralls
Copy link

coveralls commented Jun 27, 2019

Coverage Status

Coverage remained the same at 83.071% when pulling 0e3b385 on Skyge:1.x into fcaaca9 on ethereum:1.x.

docs/web3-eth.rst Outdated Show resolved Hide resolved
@nivida nivida added Documentation Relates to project wiki or documentation 1.x 1.0 related issues labels Jul 8, 2019
@nivida
Copy link
Contributor

nivida commented Jul 8, 2019

Could you open a second PR with these documentation changes for the 2.x branch? Thanks!:)

@Skyge
Copy link
Contributor Author

Skyge commented Jul 8, 2019

@nivida OK, I will do it now for the 2.x branch.

@Skyge
Copy link
Contributor Author

Skyge commented Jul 9, 2019

By the way, I am not sure what is the difference between the branch 1.x and 2.x.
And what about the branch 0.20.7, should I also make a same document PR?

@nivida nivida merged commit 21359d0 into web3:1.x Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants