Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Subscription Type #2919

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Fix Subscription Type #2919

merged 3 commits into from
Jul 15, 2019

Conversation

JunichiSugiura
Copy link

Fix return type for subscription.on method.

@coveralls
Copy link

coveralls commented Jun 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.664% when pulling c61443a on LukeSugiura:hotfix/subscription-type into c028ac3 on ethereum:2.x.

@joshstevens19 joshstevens19 added the Types Incorrect or missing types label Jul 3, 2019
@nivida nivida added 2.x 2.0 related issues In Progress Currently being worked on labels Jul 8, 2019
@nivida nivida removed the In Progress Currently being worked on label Jul 15, 2019
@nivida nivida merged commit 2493be5 into web3:2.x Jul 15, 2019
@nivida nivida mentioned this pull request Aug 5, 2019
Merged
11 tasks
@alcuadrado alcuadrado mentioned this pull request Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.x 2.0 related issues Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JunichiSugiura @coveralls @nivida @joshstevens19