switch repo fork for the websocket package #2976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
michaelsbradleyjr/Websocket-Node#polyfill/globalThis
branch uses a more robust approach to resolve a browser'swindow
object. It also includes all the latest commits on the upstream'smaster
branch, including Node v12.x compatibility and a workaround for the.git/
subdir npm bug.The
"preinstall"
script inpackages/web3-providers-ws/package.json
is removed because it's not helpful and its use ofrm
causes Windows incompatibility. Closes #2971 and #2973.packages/web3-providers-ws/src/index.js
is refactored since thewebsocket
package already does native WebSocket detection.At some point it will be preferable to install
websocket
directly from the registry, i.e. by specifying a version number/range inpackages/web3-providers-ws/package.json
but this is a way to move forward until a future release of thewebsocket
package.