Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI not failing even though tests error #3138

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Fix CI not failing even though tests error #3138

merged 2 commits into from
Oct 17, 2019

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Oct 16, 2019

This also skips a test for accounts.signTransaction which is failing now because of the changes in #3125. Have left a note there about what's wrong...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 84.867% when pulling 910e1e8 on cgewecke:fix/failing-e2e into ba56fc6 on ethereum:1.x.

@cgewecke cgewecke requested a review from nivida October 16, 2019 21:03
@nivida nivida added 1.x 1.0 related issues CI labels Oct 17, 2019
@nivida nivida merged commit 400d24b into web3:1.x Oct 17, 2019
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* Make ci.sh exit immediately on error, increase geth timeouts

* Temporarily skip E2E accounts.signTransaction test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants