Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

package.json moving @types/node to devDependancy #3337

Closed
wants to merge 1 commit into from
Closed

package.json moving @types/node to devDependancy #3337

wants to merge 1 commit into from

Conversation

cokia
Copy link
Contributor

@cokia cokia commented Jan 24, 2020 •
edited
Loading

Description

moving @types/node to a devDependency. It isn't needed at runtime, and if a library user is is targeting browser this dependency will give them incorrect type hints.

Fixes #2965

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added 1.x 1.0 related issues dependencies Review Needed Maintainer(s) need to review Types Incorrect or missing types labels Jan 24, 2020
@cokia
Copy link
Contributor Author

cokia commented Jan 24, 2020

oops, it have some error.
I'll requset PR again.
Sorry.

@cokia cokia closed this Jan 24, 2020
@cokia cokia mentioned this pull request Mar 12, 2020
Closed
10 tasks
@cokia
Copy link
Contributor Author

cokia commented Mar 12, 2020

i made a new PR #3412
please check and review it.

thanks

@cgewecke cgewecke mentioned this pull request Apr 2, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshstevens19 joshstevens19 Awaiting requested review from joshstevens19

@nivida nivida Awaiting requested review from nivida

@cgewecke cgewecke Awaiting requested review from cgewecke

Assignees
No one assigned
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review Types Incorrect or missing types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move types to devDependency.
2 participants
@cokia @nivida