Implement FakeIpcProvider.reset (#3190) #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
cgewecke
commented
Jan 28, 2020
nivida
reviewed
Jan 28, 2020
nivida
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR targets #3190
This tries to make sure the injection-based tests in
contract.jsrun the subscriptions clearing correctly when RequestManager.setProvider is called.In #3303 there was quite a bit of confusion about whether or not additional listeners are being attached on a double-call to setProvider...but it looks like the test fixture might just not reflect the code path correctly.
Type of change
Checklist: