Add subscription tests for disconnect & setProvider (#3190) #3347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR targets #3329 (If you merge 3329 first, this should go into #3190 clean, but you'll have to change the target branch).
Adds a couple final tests for #3190, describing expected behavior on
provider.disconnect
andeth.setProvider
.The provider disconnect test reproduces the error triggered in the ganache E2E, and can be seen failing in Travis here in the first commit. When a delay added between disconnect and sever shutdown, the test succeeds.
Have opened ganache-core 545 to address their test failure - they should be able to bump to a higher patch version without problems after #3190 is published.
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success and extended the tests if necessary.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.