Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription tests for disconnect & setProvider (#3190) #3347

Merged
merged 4 commits into from
Jan 30, 2020

Conversation

cgewecke
Copy link
Collaborator

@cgewecke cgewecke commented Jan 30, 2020

Description

PR targets #3329 (If you merge 3329 first, this should go into #3190 clean, but you'll have to change the target branch).

Adds a couple final tests for #3190, describing expected behavior on provider.disconnect and eth.setProvider.

The provider disconnect test reproduces the error triggered in the ganache E2E, and can be seen failing in Travis here in the first commit. When a delay added between disconnect and sever shutdown, the test succeeds.

Have opened ganache-core 545 to address their test failure - they should be able to bump to a higher patch version without problems after #3190 is published.

Type of change

  • Tests

Checklist:

  • I have selected the correct base branch. Based on Check for error codes on close in RequestManager (#3190) #3329
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@cgewecke cgewecke changed the title Add subscript behavioral tests for disconnect & setProvider Add subscription tests for disconnect & setProvider Jan 30, 2020
@coveralls
Copy link

coveralls commented Jan 30, 2020

Coverage Status

Coverage increased (+0.07%) to 88.116% when pulling e78bed7 on pri/isolation-tests into 46ebb24 on pri/connection-close.

@cgewecke cgewecke changed the base branch from pri/connection-close to provider-related-improvements January 30, 2020 08:02
@cgewecke cgewecke changed the base branch from provider-related-improvements to pri/connection-close January 30, 2020 08:02
@cgewecke cgewecke mentioned this pull request Jan 30, 2020
11 tasks
@cgewecke cgewecke added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Jan 30, 2020
@cgewecke cgewecke changed the title Add subscription tests for disconnect & setProvider Add subscription tests for disconnect & setProvider (#3190) Jan 30, 2020
test/helpers/test.utils.js Outdated Show resolved Hide resolved
@nivida nivida merged commit 2223335 into pri/connection-close Jan 30, 2020
@nivida nivida deleted the pri/isolation-tests branch January 31, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants