-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not implemented error with react native #3666
Conversation
new URL(url) -> require('url').parse(url)
another example bug
close and pr again |
This reverts commit 69f5045.
Can you please update the changelog :) |
@daoauth Do you have an example repo I could check out to verify this? I'd love to eventually add react-native support as a part of the CI run... |
https://github.com/daoauth/web3js-react-native-ws |
Co-authored-by: Wyatt Barnes <me@wyatt.email>
Changes seem to follow documentation |
@@ -1,8 +1,9 @@ | |||
var isNode = Object.prototype.toString.call(typeof process !== 'undefined' ? process : 0) === '[object process]'; | |||
var isRN = typeof navigator !== 'undefined' && navigator.product === 'ReactNative'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the correct way to check if running ReactNative
Description
from
to
Fixes #3667
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.