Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fixed web3-eth-abi typing #4100

Closed
marcj wants to merge 3 commits into from
Closed

Fixed web3-eth-abi typing #4100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
910e8b6
Fixed web3-eth-abi typing
marcj Jun 3, 2021
4c54b7d
Merge branch '1.x' into patch-1
marcj Jun 23, 2021
232c4ea
Merge branch '1.x' into patch-1
jdevcs Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/web3-eth-abi/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import { AbiInput, AbiItem } from 'web3-utils';

export class AbiCoder {
declare class AbiCoder {
encodeFunctionSignature(functionName: string | AbiItem): string;

encodeEventSignature(functionName: string | AbiItem): string;
Expand All @@ -40,3 +40,6 @@ export class AbiCoder {
topics: string[]
): { [key: string]: string };
}

declare var coder: AbiCoder;
Copy link
Contributor

@avkos avkos Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
declare var coder: AbiCoder;
declare const coder: AbiCoder;

I think you need to use const here

Copy link
Author

@marcj marcj Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need? If it doesn't match you coding style, you can change it afterwards, or close and commit yourself. For me its only important that this bug gets fixed, not how.

Copy link
Contributor

@avkos avkos Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fix it, please. and also check tests. They do not pass after your changes.

export default coder;