EIP-1559 support for web3.eth.sendTransaction #4220
Conversation
|
Your Render PR Server URL is https://web3-js-pr-4220.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c44eq3ht9ds8sa1ccvr0. |
| payload.params[0].gasPrice = gasPrice; | ||
| } | ||
| _handleTxPricing(method, payload.params[0]).then(txPricing => { | ||
| payload.params[0] = {...payload.params[0], ...txPricing}; |
There was a problem hiding this comment.
Would it make more sense to move all this logic outside of the blocks?
Regardless of how its being sent, we should just update the TX accordingly
There was a problem hiding this comment.
I think in this case, we only want to add gas pricing info to the payload object if the info is not already provided for specifically sendTxs, otherwise the code shouldn't be executed
Pull Request Test Coverage Report for Build 1099905485
💛 - Coveralls |
|
Hi @spacesailor24, are we planning on closing this before the hardfork? |
@williamsfu99 yep, that's the plan, however we're having trouble getting the Ganache test suite to pass |
@spacesailor24 just so you know, Ganache doesn't support London yet (and won't til Ganache v7). |
|
This pull request introduces 1 alert and fixes 1 when merging 3ef9420 into d0d82b4 - view on LGTM.com new alerts:
fixed alerts:
|
|
This is just waiting approvals now |
|
v1.5.1-rc.1 contains this fix FYI Not sure when |
|
Just saw the release candidate and tested this and can confirm that it works. :) Edit: Also our CI with it is passing too. :) |
|
v1.5.1 has been released |
|
Thank you for your tireless work getting this out, @spacesailor24 |
Adds EIP-1559 support to
web3.eth.sendTransactioncloses #4211