Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrectly versioned bn.js type export #4418

Merged
merged 4 commits into from
Oct 7, 2021
Merged

fix incorrectly versioned bn.js type export #4418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7571b2d
fix incorrectly versioned bn.js type export
mrice32 Oct 1, 2021
73ff335
WIP
mrice32 Oct 1, 2021
d2d28cc
WIP
mrice32 Oct 6, 2021
557648d
Merge branch '1.x' into fix_bn_export
mrice32 Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,3 +472,4 @@ Released with 1.0.0-beta.37 code base.
- Format `block.baseFeePerGas` to number (#4330)
- Correct `web3-eth-personal.sendTransaction` example in documentation (#4409)
- Updated README to include Webpack 5 angular support instructions (#4174)
- - Added @types/bn.js dependency to additional packages (notably web3-utils) so the type export aligns with the js.
Copy link
Contributor

@spacesailor24 spacesailor24 Oct 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- - Added @types/bn.js dependency to additional packages (notably web3-utils) so the type export aligns with the js.
- Added @types/bn.js dependency to additional packages (notably web3-utils) so the type export aligns with the js (#4418)

Extra - and missing PR number

Loading