Fix buggy BlockHeader ts interface
#4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested changes
Oct 14, 2021
There was a problem hiding this comment.
@karim-en Thanks for the contribution, I am running the CI jobs on this PR to see if something related is broken.
Meanwhile can you please look into these two tests and see if these are related to change.
I would also suggest that you create an a bug issue on web3 repo and then link your PR to that issue.
Pull Request Test Coverage Report for Build 1408779542
💛 - Coveralls |
|
@karim-en Did you get a chance to look into above message? |
Oh, thanks for bumping me, I missed your message, I am going to check that |
|
@karim-en We look forward for your update on this PR so we can merge it. |
Done. sorry for the delay. |
nazarhussain
approved these changes
Nov 4, 2021
spacesailor24
changed the base branch from
1.x
to
wyatt/1.x/fix-blockheader-typing
|
Taking over PR to update |
Merged
spacesailor24
added a commit
that referenced
this pull request
Nov 10, 2021
* Fix buggy `BlockHeader` ts interface (#4452) * Fix buggy `BlockHeader` ts interface * Fix `receiptsRoot` property in the unit test Co-authored-by: Nazar Hussain <nazarhussain@gmail.com> * Update CHANGELOG Co-authored-by: Karim <karimkaspersky@yahoo.com> Co-authored-by: Nazar Hussain <nazarhussain@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The name of the
receiptRootproperty is not correct and we should usereceiptsRootinstead.wiki:
https://eth.wiki/json-rpc/API#:~:text=of%20the%20block.-,receiptsRoot,-%3A
Related Issue
Resolve #4517
ethereum/go-ethereum#3084
Type of change