Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS package #4669

Merged
merged 2 commits into from
Jan 7, 2022
Merged

ENS package #4669

merged 2 commits into from
Jan 7, 2022

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jan 6, 2022

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@jdevcs jdevcs linked an issue Jan 6, 2022 that may be closed by this pull request
@nazarhussain
Copy link
Contributor

@jdevcs I approved the PR, but there is no issue linked with it. Please create an issue and link to this PR.

@nazarhussain nazarhussain added the 4.x 4.0 related label Jan 6, 2022
@jdevcs jdevcs merged commit 24b4ca7 into 4.x Jan 7, 2022
@jdevcs jdevcs deleted the junaid/ens-package branch January 7, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create web3-eth-ens package structure for the 4.x
4 participants