Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing web3.eth.Contract.setProvider() as per public documentation #4822

Merged
merged 13 commits into from
May 4, 2022
Merged

Exposing web3.eth.Contract.setProvider() as per public documentation #4822

Changes from 4 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
40ec263
Exposing web3.eth.Contract.setProvider() as per public documentation
sdesalas Mar 4, 2022
66ac73f
Merge branch '1.x' into 1.x
jdevcs Mar 16, 2022
4a2ffb9
Merge branch '1.x' into 1.x
jdevcs Mar 17, 2022
7a28575
Merge branch '1.x' into 1.x
nazarhussain Mar 18, 2022
4fe713f
Additional TS defs for web3.eth.Contract.setProvider() as suggested (…
sdesalas Mar 20, 2022
272e098
Additional TS defs for web3.eth.Contract.setProvider()
sdesalas Mar 20, 2022
b146e39
Merge branch '1.x' into 1.x
sdesalas Mar 24, 2022
48e9115
Merge branch '1.x' into 1.x
sdesalas Apr 6, 2022
306ad7a
Merge branch '1.x' into 1.x
jdevcs Apr 11, 2022
5e4ca3b
Merge branch '1.x' into 1.x
jdevcs Apr 14, 2022
6f65eca
Merge branch '1.x' into 1.x
sdesalas Apr 18, 2022
471534b
Merge branch '1.x' into 1.x
sdesalas Apr 21, 2022
a5057b8
Merge branch '1.x' into 1.x
sdesalas Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/web3-eth-contract/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export class Contract {
options?: ContractOptions
);

static setProvider(provider: string): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setProvider accepts an additional parameter for accounts as well.

https://github.com/ChainSafe/web3.js/blob/832271a38e555fa62c843a05aba4eb5514f53d8a/packages/web3-eth-contract/src/index.js#L338

Copy link
Author

@sdesalas sdesalas Mar 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya, thanks good point. Added TS defs for optional accounts parameter as suggested.

Copy link
Author

@sdesalas sdesalas Mar 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And parameter provider is of type provider too (from web3-core). Fixing.


private _address: string;
private _jsonInterface: AbiItem[];
defaultAccount: string | null;
Expand Down