Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build command #4848

Closed
wants to merge 9 commits into from
Closed

Fix build command #4848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e402865
Use && instead of ; to join composite commands
wbt Mar 14, 2022
771c2b2
npm i rimraf --save-dev
wbt Mar 14, 2022
cf7a047
Change command to run rimraf
wbt Mar 14, 2022
b875b14
npm i
wbt Mar 14, 2022
8147b4d
Cut redundant command covered in test:cov
wbt Mar 14, 2022
0f1eb0c
Split checklist item into 2
wbt Mar 14, 2022
92cf679
Use 'have' for grammatical consistency
wbt Mar 14, 2022
ce80a9c
Add bash keyword before script source
wbt Mar 14, 2022
9f790fd
Add line to changelog with PR #
wbt Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ Fixes #(issue)
- [ ] My changes generate no new warnings.
- [ ] Any dependent changes have been merged and published in downstream modules.
- [ ] I ran `npm run dtslint` with success and extended the tests and types if necessary.
- [ ] I ran `npm run test:unit` with success.
- [ ] I ran `npm run test:cov` and my test cases cover all the lines and branches of the added code.
- [ ] I ran `npm run build` and tested `dist/web3.min.js` in a browser.
- [ ] I ran `npm run build` with success.
- [ ] I have tested the built `dist/web3.min.js` in a browser.
- [ ] I have tested my code on the live network.
- [ ] I have checked the Deploy Preview and it looks correct.
- [ ] I have updated the `CHANGELOG.md` file in the root folder.
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,5 +522,6 @@ Released with 1.0.0-beta.37 code base.
- Ran `npm audit fix` to address vulnerabilities and update libraries (#4719) (#4728)

## [Unreleased]
- Improve npm script commands for development purposes (#4848)

## [1.8.0]
Loading