Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 23, 2022

Changed

Security

Fixed

@jdevcs jdevcs added the 4.x 4.0 related label Mar 23, 2022
@jdevcs jdevcs self-assigned this Mar 23, 2022
@render
Copy link

render bot commented Mar 23, 2022

@coveralls
Copy link

coveralls commented Mar 23, 2022

Pull Request Test Coverage Report for Build 2104774299

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 429 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-2.3%) to 72.21%

Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 2029198956: -2.3%
Covered Lines: 3368
Relevant Lines: 4396

💛 - Coveralls

@jdevcs jdevcs added 1.x 1.0 related issues and removed 4.x 4.0 related labels Mar 24, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Mar 24, 2022

As part of the RC process, following test installations are performed in other projects and running their tests to see if everything.

  • installs properly
  • builds
  • tests pass

(This list will be actively edited)

Project Desc Status
oz-test-helpers Test utils. Subset of their suite is web3 contracts
synthetix ~1000 units

@jdevcs jdevcs added the Release label Mar 24, 2022
@jdevcs jdevcs marked this pull request as ready for review April 4, 2022 15:18
@jdevcs jdevcs added the Review Needed Maintainer(s) need to review label Apr 4, 2022
@jdevcs jdevcs changed the title v1.7.2-rc.0 v1.7.2 Apr 6, 2022
@jdevcs
Copy link
Contributor Author

jdevcs commented Apr 6, 2022

eth2 test was failing with latest lighthouse docker image

FAIL test/schemaMethods.test.ts
  ● getBlockAttestations

    expect(received).toMatchObject(expected)

    Matcher error: received value must be a non-null object

    Received has value: undefined

      270 |
      271 |     const response = await eth2BeaconChain.getBlockAttestations(routeParameters)
    > 272 |     expect(response[0]).toMatchObject(expectedResponse)
          |                         ^
      273 | })
      274 |
      275 | /**

      at _callee14$ (test/schemaMethods.test.ts:272:25)
      at tryCatch (node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:63:40)
      at Generator.invoke [as _invoke] (node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:294:22)
      at Generator.next (node_modules/@babel/runtime/node_modules/regenerator-runtime/runtime.js:119:21)
      at asyncGeneratorStep (node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
      at _next (node_modules/@babel/runtime/helpers/asyncToGenerator.js:25:9)

PASS test/constructor.test.ts

Test Suites: 1 failed, 1 passed, 2 total
Tests:       1 failed, 1 skipped, 21 passed, 23 total
Snapshots:   0 total
Time:        2.437 s

This test is passing with lighthouse v2.1.5

@jdevcs
Copy link
Contributor Author

jdevcs commented Apr 7, 2022

lighthouse v2.2.0 sigp/lighthouse#3147

@jdevcs
Copy link
Contributor Author

jdevcs commented Apr 11, 2022

Closing this PR without merging to 1.x as there was issue in 1.7.2 release.
1.7.3 was branched off from 1.7.2 and it have fix of build issue, so will merge 1.7.3 into 1.x .

@jdevcs jdevcs closed this Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Release Review Needed Maintainer(s) need to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants