4811/investigate eslint errors in web3 eth #4893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested changes
Mar 29, 2022
There was a problem hiding this comment.
@nikoulai Please change the base branch of this PR to the one you started with. Currently it contains a lot of extra commits and unable to identify change related to this PR.
nikoulai
changed the base branch from
4.x
to
wyatt/4.x/4810-web3-eth-promievent-tests
…:ChainSafe/web3.js into wyatt/4.x/4810-web3-eth-promievent-tests
Base automatically changed from
wyatt/4.x/4810-web3-eth-promievent-tests
to
4.x
March 31, 2022 10:43
nikoulai
changed the base branch from
4.x
to
wyatt/4.x/4810-web3-eth-promievent-tests
…estigate-eslint-errors-in-web3-eth
spacesailor24
changed the base branch from
wyatt/4.x/4810-web3-eth-promievent-tests
to
4.x
spacesailor24
approved these changes
Apr 8, 2022
luu-alex
approved these changes
Apr 8, 2022
nazarhussain
approved these changes
Apr 11, 2022
|
This pull request introduces 6 alerts when merging df69558 into 8e57d5a - view on LGTM.com new alerts:
|
nikoulai
force-pushed
the
4811/investigate-eslint-errors-in-web3-eth
branch
from
df69558
to
af25dc9
Compare
nikoulai
force-pushed
the
4811/investigate-eslint-errors-in-web3-eth
branch
from
af25dc9
to
5388337
Compare
…github.com/ChainSafe/web3.js into 4811/investigate-eslint-errors-in-web3-eth
nikoulai
force-pushed
the
4811/investigate-eslint-errors-in-web3-eth
branch
from
9b3fbee
to
ff75a8c
Compare
jdevcs
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4811
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.