Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating web3 utils BN #5132

Merged
merged 2 commits into from
Jun 14, 2022
Merged

updating web3 utils BN #5132

merged 2 commits into from
Jun 14, 2022

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Jun 14, 2022

Was testing 1.7.4-rc.1 and many open zeppelin testcases were breaking due to the change of updating BN, this was due to us adding BNwrapped and not adding the prototype and attributes.

This PR adds the methods/attributes to the BN object and allows the synthetix tests to pass.

@render
Copy link

render bot commented Jun 14, 2022

@luu-alex luu-alex mentioned this pull request Jun 14, 2022
@coveralls
Copy link

coveralls commented Jun 14, 2022

Pull Request Test Coverage Report for Build 2496163757

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 72.174%

Totals Coverage Status
Change from base Build 2460883276: 0.02%
Covered Lines: 3382
Relevant Lines: 4415

💛 - Coveralls

Copy link
Contributor

@nazarhussain nazarhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing I observed is that the bundle size for this RC release is increased. Do you suspect any particular reason for it?

packages/web3-utils/src/utils.js Outdated Show resolved Hide resolved
@luu-alex
Copy link
Contributor Author

@nazarhussain has the bundlesize increased? running npm run bundlesize locally for both 1.7.3 and 1.7.4-rc.1 give me the size of 1.39mb

@nazarhussain
Copy link
Contributor

@luu-alex Please check this https://bundlephobia.com/package/web3@1.7.3

@luu-alex
Copy link
Contributor Author

@nazarhussain Ah I see, I believe the bundle size becoming larger is due to upgrading ether packages we were using. To note, our bundle now includes @ethersproject/signing-key@5.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants