-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating web3 utils BN #5132
updating web3 utils BN #5132
Conversation
Your Render PR Server URL is https://web3-js-pr-5132.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cajti94gqg46e5e17g3g. |
Pull Request Test Coverage Report for Build 2496163757
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing I observed is that the bundle size for this RC release is increased. Do you suspect any particular reason for it?
@nazarhussain has the bundlesize increased? running |
@luu-alex Please check this https://bundlephobia.com/package/web3@1.7.3 |
@nazarhussain Ah I see, I believe the bundle size becoming larger is due to upgrading ether packages we were using. To note, our bundle now includes @ethersproject/signing-key@5.6.2 |
Was testing 1.7.4-rc.1 and many open zeppelin testcases were breaking due to the change of updating BN, this was due to us adding
BNwrapped
and not adding the prototype and attributes.This PR adds the methods/attributes to the BN object and allows the synthetix tests to pass.