Specify SignTransaction's argument types #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…ns-argument-is-not-typed-in-web3-types
Deploying with
|
| Latest commit: |
a095170
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fababd98.web3-js-docs.pages.dev |
| Branch Preview URL: | https://5892-4x-signtransactions-arg.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #5993 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 156 156
Lines 7406 7408 +2
Branches 2008 2006 -2
=======================================
+ Hits 6356 6358 +2
Misses 1050 1050
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Muhammad-Altabba
requested review from
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
as code owners
avkos
requested changes
Apr 10, 2023
|
Except for Oleksii's comment LGTM |
nikoulai
approved these changes
Apr 10, 2023
jdevcs
requested changes
Apr 11, 2023
|
This PR lgtm, except few changes required. Thanks @Muhammad-Altabba |
|
Some of tests in CI are not passing and there are conflicting files. Could you fix these. Many thanks |
…ns-argument-is-not-typed-in-web3-types
avkos
approved these changes
Apr 11, 2023
jdevcs
approved these changes
Apr 13, 2023
Muhammad-Altabba
deleted the
5892-4x-signtransactions-argument-is-not-typed-in-web3-types
branch
Merged
spacesailor24
pushed a commit
that referenced
this pull request
Apr 18, 2023
* move some data-format and contract types to web3-types * at `signTransaction` use `Transaction` instead of `Record<string, unknown>` * update CHANGELOG.md files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5892
Type of change
Checklist for 1.x:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.Checklist for 4.x:
yarnsuccessfullyyarn lintsuccessfullyyarn build:websuccessfullyyarn test:unitsuccessfullyyarn test:integrationsuccessfullycompile:contractssuccessfullyCHANGELOG.mdfile in the packages I have edited.