Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction integration tests #6071

Merged
merged 18 commits into from
May 25, 2023
Merged

transaction integration tests #6071

merged 18 commits into from
May 25, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 8, 2023

Description

#6013

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs added the 4.x 4.0 related label May 8, 2023
@@ -220,15 +218,6 @@ export async function defaultTransactionBuilder<ReturnType = Transaction>(option
populatedTransaction.accessList = [];
}

populatedTransaction = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: #6063

Copy link
Contributor Author

@jdevcs jdevcs May 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gas price is already assigned in sendTransaction and at this place its called again

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 8, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7168920
Status: ✅  Deploy successful!
Preview URL: https://e7b52b70.web3-js-docs.pages.dev
Branch Preview URL: https://junaid-4xtxtests.web3-js-docs.pages.dev

View logs

@github-actions
Copy link

github-actions bot commented May 8, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 645 KB 645 KB 38 bytes 0.01%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 628 KB 628 KB 38 bytes 0.01%
../lib/commonjs/index.d.ts 8.43 KB 8.43 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.37 KB 2.37 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/web3.d.ts 808 bytes 808 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@jdevcs
Copy link
Contributor Author

jdevcs commented May 15, 2023

This PR is blocked due to bug : #6065

once second auto gas filling function call is not called for sendTransaction, in CI many tests are not passing : Eip1559GasPriceError: Invalid value given "0x15ab1a16". Error: eip-1559 transactions don't support gasPrice. web3-eth: 227 | // for the same code executing in 1.x web3-eth: 228 | if (!isNullish(transaction.gasPrice) && transaction.type === '0x2') web3-eth: > 229 | throw new Eip1559GasPriceError(transaction.gasPrice); web3-eth: | ^ web3-eth: 230 | if (transaction.type === '0x0' || transaction.type === '0x1') web3-eth: 231 | throw new UnsupportedFeeMarketError({ web3-eth: 232 | maxFeePerGas: transaction.maxFeePerGas, web3-eth: at validateFeeMarketGas (src/validation.ts:229:9) web3-eth: at validateGas (src/validation.ts:279:23) web3-eth: at validateTransactionForSigning (src/validation.ts:300:13) web3-eth: at src/utils/prepare_transaction_for_signing.ts:139:31

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #6071 (7168920) into 4.x (bf1311f) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6071      +/-   ##
==========================================
- Coverage   87.41%   87.40%   -0.01%     
==========================================
  Files         199      199              
  Lines        7614     7616       +2     
  Branches     2065     2067       +2     
==========================================
+ Hits         6656     6657       +1     
- Misses        958      959       +1     
Flag Coverage Δ
UnitTests 87.40% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@@ -77,8 +77,12 @@ describe('web3.accounts', () => {
}),
).resolves.toBeDefined();

const txWithGas = {
...tx,
gasPrice: '0x271000',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added gasPrice explicitly in tests of this file, because now signTransaction will not fill gas price and validation fails if no gasprice or gas0x2 params are provided .

});
};

return web3.eth.sendTransaction(txObj, undefined, { checkRevertBeforeSending: false });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use internal signing, as sendTransaction auto fills gas price if not provided,

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

I think we need to mention in the Added section at CHANGELOG.md that the fillGasPrice parameter has been added to transactionBuilder.

@jdevcs jdevcs requested a review from spacesailor24 May 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x 4.0 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants