Add .on('error') test for reverted contract methods
#6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
0603716
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://635265bb.web3-js-docs.pages.dev |
| Branch Preview URL: | https://wyatt-4-x-5670-contract-meth.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6194 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 197 197
Lines 7557 7557
Branches 2060 2060
=======================================
Hits 6610 6610
Misses 947 947
Flags with carried forward coverage won't be shown. Click here to find out more.
|
spacesailor24
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Muhammad-Altabba
approved these changes
Jun 19, 2023
packages/web3-eth-contract/test/integration/contract_methods_errors.test.ts
Show resolved
Hide resolved
packages/web3-eth-contract/test/integration/contract_methods_errors.test.ts
Outdated
Show resolved
Hide resolved
| @@ -75,6 +75,27 @@ describe('contract errors', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should catch Unauthorized error PromiEvent.on("error")', async () => { | |||
| const expectedThrownError = { | |||
There was a problem hiding this comment.
I think it would be nice if we have this const expectedThrownError = {... above and we use it inside the 2 related test cases which related to the Unauthorized() error.
| @@ -101,5 +122,27 @@ describe('contract errors', () => { | |||
| }, | |||
| }); | |||
| }); | |||
|
|
|||
| it('should catch error with parameter using PromiEvent.on("error")', async () => { | |||
| const expectedThrownError = { | |||
There was a problem hiding this comment.
I think it would be nice if we have this const expectedThrownError = {... above and we use it inside the 2 related test cases which related to the CustomError error.
jdevcs
approved these changes
Jun 20, 2023
…rrors.test.ts Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
…rrors.test.ts Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
luu-alex
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds two tests that verify we receive the revert error using
.on('error')when calling a contract method that revertsrelated to #5670