Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x - update submit work and contract.myMethod.send docs #6229

Merged
merged 7 commits into from
Jul 13, 2023
Merged

1.x - update submit work and contract.myMethod.send docs #6229

merged 7 commits into from
Jul 13, 2023

Conversation

luu-alex
Copy link
Contributor

Description

#5200
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
https://web3js.readthedocs.io/en/v1.7.4/web3-eth-contract.html#methods-mymethod-send
myContract.methods.myMethod([param1[, param2[, ...]]]).send(options[, callback])

should be myContract.methods.myMethod(param1, param2,...).send(options[, callback])

and submitwork should not take in a list but

should be web3.eth.submitWork( "0x0000000000000001", "0x1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef", "0xD1FE5700000000000000000000000000D1FE5700000000000000000000000000" )

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@luu-alex luu-alex changed the base branch from 4.x to 1.x June 26, 2023 22:49
@luu-alex luu-alex closed this Jun 26, 2023
@luu-alex luu-alex reopened this Jun 26, 2023
@luu-alex luu-alex added Documentation Relates to project wiki or documentation 1.x 1.0 related issues labels Jun 26, 2023
@Muhammad-Altabba Muhammad-Altabba self-requested a review July 3, 2023 07:50
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Pull Request Test Coverage Report for Build 5465425467

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.146%

Totals Coverage Status
Change from base Build 5415918353: 0.0%
Covered Lines: 3353
Relevant Lines: 4212

💛 - Coveralls

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing CI tests in this PR should be fixed under : #6242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants