Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for ABI encoding large negative ints #6239

Merged
merged 11 commits into from
Jun 29, 2023
Merged

Fix for ABI encoding large negative ints #6239

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a2dfaa9
Bump typescript version to 4.9.5
spacesailor24 Jun 27, 2023
c2fe977
Update CHANGELOG
spacesailor24 Jun 27, 2023
2a8fe13
Bump ts-node to 10.9.1
spacesailor24 Jun 27, 2023
a8ce1c2
Fix issue with encoding large negative numbers
spacesailor24 Jun 28, 2023
1b0b73e
Correct test cases for check-address-checksum-test
spacesailor24 Jun 28, 2023
f2f7c55
Merge branch 'wyatt/1.x/typescript-build-fix' into wyatt/1.x/5890-abi…
spacesailor24 Jun 28, 2023
a6f27ea
dtslint debug
spacesailor24 Jun 28, 2023
621ab4b
Merge branch 'wyatt/1.x/typescript-build-fix' into wyatt/1.x/5890-abi…
spacesailor24 Jun 28, 2023
b6c4e81
Convert if/else to ternary
spacesailor24 Jun 28, 2023
d284c48
Merge branch '1.x' into wyatt/1.x/5890-abi-encoding-ints
spacesailor24 Jun 28, 2023
10e2420
Update CHANGELOG
spacesailor24 Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/web3-eth-abi/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,8 +268,11 @@ ABICoder.prototype.formatParam = function (type, param) {
if (match) {
let size = parseInt(match[2] || "256");
if (size / 8 < param.length) {
// pad to correct bit width
param = utils.leftPad(param, size);
param = param.startsWith("-")
// pad to correct bit width, with - at the beginning
? `-${utils.leftPad(param.substring(1), size)}`
// pad to correct bit width
: utils.leftPad(param, size);
}
}

Expand Down
3 changes: 3 additions & 0 deletions test/eth.abi.encodeParameter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ var tests = [{
},{
params: ['bytes32[]', ['0xdf3234', '0xfdfd']],
result: '0x00000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000002df32340000000000000000000000000000000000000000000000000000000000fdfd000000000000000000000000000000000000000000000000000000000000'
},{
params: ['int128', '-170141183460469231731687303715884105727'],
result: '0xffffffffffffffffffffffffffffffff80000000000000000000000000000001'
}];

describe('encodeParameter', function () {
Expand Down
Loading