-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump cross-fetch to version 4 #6463
Conversation
Fixes issues like lquixada/cross-fetch#78, enabling to run web3.js in service worker
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6463 +/- ##
=======================================
Coverage 89.39% 89.39%
=======================================
Files 212 212
Lines 8137 8137
Branches 2213 2213
=======================================
Hits 7274 7274
Misses 863 863
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Changelog needs to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, update changelog as mentioned by Alex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rdvorkin,
I also updated the CHANGELOG.md file
Fixes issues like lquixada/cross-fetch#78, enabling to run web3.js in service worker