Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stress Tests 3 - create long duration ws tests #6588

Merged
merged 14 commits into from
Nov 20, 2023
Merged

Stress Tests 3 - create long duration ws tests #6588

merged 14 commits into from
Nov 20, 2023

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Nov 10, 2023

Description

Stress Tests ( These tests should be automated but not integrated in github CI actions, so we can invoke these tests locally any time when required )

Keeping the connection open for a longer duration of time (10 hours manual test) and sending request after some constant interval ( 10 min ) at end of test time display number of requests failed if any or connection interrupted. This test can be done on some testnet Infura endpoint.

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

cloudflare-workers-and-pages bot commented Nov 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fef8fe2
Status: ✅  Deploy successful!
Preview URL: https://4dd42370.web3-js-docs.pages.dev
Branch Preview URL: https://5564.web3-js-docs.pages.dev

View logs

Copy link

github-actions bot commented Nov 10, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 589 KB 589 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 571 KB 571 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.67 KB 3.67 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #6588 (d5d2c68) into 4.x (4358140) will increase coverage by 2.19%.
Report is 112 commits behind head on 4.x.
The diff coverage is 92.95%.

❗ Current head d5d2c68 differs from pull request most recent head fef8fe2. Consider uploading reports for the commit fef8fe2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6588      +/-   ##
==========================================
+ Coverage   87.37%   89.57%   +2.19%     
==========================================
  Files         197      215      +18     
  Lines        7548     8276     +728     
  Branches     2059     2242     +183     
==========================================
+ Hits         6595     7413     +818     
+ Misses        953      863      -90     
Flag Coverage Δ
UnitTests 89.57% <92.95%> (+2.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. we need to have a convention regarding file structure

@avkos avkos self-requested a review November 13, 2023 17:23
@luu-alex luu-alex changed the title Stress Tests 3 - QA Tests 5564 Stress Tests 3 - create long duration ws tests Nov 14, 2023
Copy link

@TokenPayId TokenPayId left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good alex,
However, I have just 2 comments, in addition to Junaid comments.

package.json Outdated Show resolved Hide resolved
packages/web3/test/stress/manual/nodejs_test/connection.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
However, would like to have the webpage test done with cypress. Also in the readme, you wrote test:manual but currently there is no command with this exact name. Do you plan to have this in another MR which would contain multiple manual tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants