This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Errors not caught in 4.x #6623
Merged
Errors not caught in 4.x #6623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avkos
requested review from
Muhammad-Altabba,
jdevcs and
luu-alex
as code owners
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with
|
| Latest commit: |
a368780
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3cf001df.web3-js-docs.pages.dev |
| Branch Preview URL: | https://ok-6500-errors-not-caught-in.web3-js-docs.pages.dev |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6623 +/- ##
=======================================
Coverage 90.25% 90.25%
=======================================
Files 214 214
Lines 8088 8089 +1
Branches 2163 2163
=======================================
+ Hits 7300 7301 +1
Misses 788 788
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/web3-eth-contract/test/integration/contract_erc20.test.ts
Outdated
Show resolved
Hide resolved
jdevcs
approved these changes
Nov 29, 2023
Contributor
jdevcs
left a comment
jdevcs
left a comment
There was a problem hiding this comment.
also add changelogs before merging
Muhammad-Altabba
approved these changes
Dec 4, 2023
Contributor
Muhammad-Altabba
left a comment
Muhammad-Altabba
left a comment
There was a problem hiding this comment.
Thanks @avkos,
Could you please also increase the test coverage?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6500
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.