Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@avkos
Copy link
Contributor

@avkos avkos commented Jan 18, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Fixes #6686

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 618 KB 618 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 601 KB 601 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 999 bytes 999 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

@github-actions
Copy link

github-actions bot commented Jan 18, 2024

Benchmark

Benchmark suite Current: 1681f1a Previous: 6c075db Ratio
processingTx 9491 ops/sec (±4.51%) 9301 ops/sec (±4.81%) 0.98
processingContractDeploy 40342 ops/sec (±7.02%) 39129 ops/sec (±7.62%) 0.97
processingContractMethodSend 19904 ops/sec (±6.38%) 19443 ops/sec (±5.19%) 0.98
processingContractMethodCall 40412 ops/sec (±5.32%) 38971 ops/sec (±6.34%) 0.96
abiEncode 47361 ops/sec (±6.80%) 44252 ops/sec (±6.92%) 0.93
abiDecode 31916 ops/sec (±7.68%) 30419 ops/sec (±8.89%) 0.95
sign 1683 ops/sec (±0.99%) 1656 ops/sec (±4.08%) 0.98
verify 384 ops/sec (±3.10%) 373 ops/sec (±0.78%) 0.97

This comment was automatically generated by workflow using github-action-benchmark.

@codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Merging #6732 (1681f1a) into 4.x (028dc20) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6732   +/-   ##
=======================================
  Coverage   92.03%   92.03%           
=======================================
  Files         214      214           
  Lines        8171     8171           
  Branches     2200     2200           
=======================================
  Hits         7520     7520           
  Misses        651      651           
Flag Coverage Δ
UnitTests 92.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 18, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fd56a0b
Status: ✅  Deploy successful!
Preview URL: https://ccae0c0d.web3-js-docs.pages.dev
Branch Preview URL: https://ok-6686-v4-tests---testing-t-7k16.web3-js-docs.pages.dev

View logs

@avkos
Copy link
Contributor Author

avkos commented Jan 18, 2024

Improvements I've applied:

  • I’ve moved from artifacts to cache to save time from tar pack/unpack and uploading/downloading time.
    CJS Build script time: 1m 12s. (was 1m 51s)

My investigations to decrease test time:

  • we can run all packages and all tests in the package in parallel. for this, I’ve fixed all tests to make separate refilled and unlocked wallets for each test. But it doesn’t make sense because the amount of parallel process jest count equals the of amount CPUs. In free GitHub actions, we have 2 CPUs. To use this opportunity we need to have custom GitHubActions machines that have more CPUs
  • we can run each package as an individual process in GitHub Actions. But as we use a free plan we have limited concurrent process amount. Only 20 processes. https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
  • set this to jest.config
transform: {
  '^.+\\.(ts|tsx)$': ['ts-jest', { isolatedModules: true, }],
}

this option switched off type checking in tests which decreases processing time. In our case, it is just 1-5 seconds. That is why I’ve decided not to use this option.

@avkos avkos changed the title v4 Tests - Testing time only Github action config [DRAFT] v4 Tests - Testing time only Github action config Jan 18, 2024
@avkos avkos merged commit aac2420 into 4.x Jan 24, 2024
@avkos avkos deleted the ok/6686-v4-Tests---Testing-time-only-ga-config branch January 24, 2024 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4 Tests - Testing time

3 participants