Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): Add the missing types to the ”accounts“ #6762

Closed
wants to merge 7 commits into from

Conversation

electroluxcode
Copy link

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

According to the documentation at https://docs.web3js.org/libdocs/Accounts, add the missing types to the account

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @electroluxcode for your catch and the MR.
Could you please respond to the suggestion below. And update the packages/web3/CHANGELOG.md file?

It will be also nice and helpful to write small Unit tests inside the web3 package for those added functions.

packages/web3/src/types.ts Outdated Show resolved Hide resolved
electroluxcode and others added 2 commits January 29, 2024 18:23
Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.03%. Comparing base (4358140) to head (3f0c15f).
Report is 229 commits behind head on 4.x.

❗ Current head 3f0c15f differs from pull request most recent head c7f8344. Consider uploading reports for the commit c7f8344 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6762      +/-   ##
==========================================
+ Coverage   87.37%   92.03%   +4.65%     
==========================================
  Files         197      214      +17     
  Lines        7548     8171     +623     
  Branches     2059     2200     +141     
==========================================
+ Hits         6595     7520     +925     
+ Misses        953      651     -302     
Flag Coverage Δ
UnitTests 92.03% <ø> (+4.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your contribution.
Please fix lint test

@jdevcs
Copy link
Contributor

jdevcs commented Feb 28, 2024

LGTM. Thanks for your contribution. Please fix lint test

@electroluxcode could you fix conflicting file and above comments, Thanks

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Apr 29, 2024
@jdevcs jdevcs removed the Stale Has not received enough activity label Apr 29, 2024
@jdevcs
Copy link
Contributor

jdevcs commented Apr 29, 2024

closing this PR as it will be merged via #7011 Thanks @electroluxcode

@jdevcs jdevcs closed this Apr 29, 2024
@luu-alex luu-alex mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants