add eventemitter3 #6823
add eventemitter3 #6823
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Benchmark
This comment was automatically generated by workflow using github-action-benchmark. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6823 +/- ##
==========================================
+ Coverage 87.37% 91.98% +4.61%
==========================================
Files 197 215 +18
Lines 7548 8162 +614
Branches 2059 2201 +142
==========================================
+ Hits 6595 7508 +913
+ Misses 953 654 -299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -97,23 +97,6 @@ describe('IPCProvider', () => { | |||
| expect(end).toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it('connection error', async () => { | |||
There was a problem hiding this comment.
removed connection error test, mock implementation doesn't seem to emit error for this one unit test so i added an integration test to substitute it
https://github.com/web3/web3.js/pull/6823/files#diff-ea6da20dfb39c75b95f9a7cb4cf0e3f9d1e353fe0aab69f28ef83497e86ff556R140
| @@ -755,7 +756,7 @@ describe('Contract', () => { | |||
|
|
|||
| const clonnedContract = contract.clone(); | |||
|
|
|||
| expect(JSON.stringify(contract)).toStrictEqual(JSON.stringify(clonnedContract)); | |||
| expect(stringify(contract)).toStrictEqual(stringify(clonnedContract)); | |||
There was a problem hiding this comment.
eventemitter3 has a circular structure so we use stringify library to parse properly
There was a problem hiding this comment.
TypeError: Converting circular structure to JSON
--> starting at object with constructor 'EventEmitter'
| @@ -85,28 +85,14 @@ describe('WebSocketProvider', () => { | |||
| ws.disconnect(code, data); | |||
| expect(close).toHaveBeenCalledWith(code, data); | |||
| }); | |||
| it('connection error', async () => { | |||
There was a problem hiding this comment.
removed connection error test, mock implementation doesn't seem to emit error for this one unit test so i added an integration test to substitute it
https://github.com/web3/web3.js/pull/6823/files#diff-ea6da20dfb39c75b95f9a7cb4cf0e3f9d1e353fe0aab69f28ef83497e86ff556R140
luu-alex
requested review from
avkos,
jdevcs and
Muhammad-Altabba
as code owners
Its not showing difference |
replacing nodejs and web3js implemetation of eventemitter for the usage of eventemitter3 for react-native compatibiltiy.
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.