Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blackbox test #6873

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Fix blackbox test #6873

merged 2 commits into from
Mar 8, 2024

Conversation

avkos
Copy link
Contributor

@avkos avkos commented Mar 7, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@avkos
Copy link
Contributor Author

avkos commented Mar 7, 2024

image

@jdevcs jdevcs merged commit 9e03fd7 into release/4.6.0 Mar 8, 2024
@jdevcs jdevcs deleted the ok/6872-Fix-BlackBox-tests branch March 8, 2024 14:49
jdevcs added a commit that referenced this pull request Mar 8, 2024
@jdevcs @avkos
Release/4.6.0 (#6869)
e383ae3 
* lerna version bumps

* changelog updates

* Fix blackbox test (#6873)

* Fix blackbox test

* revert

---------

Co-authored-by: Oleksii Kosynskyi <oleksii.kosynskyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs approved these changes

@luu-alex luu-alex Awaiting requested review from luu-alex

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avkos @jdevcs