-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7202 account abstraction #7311
7202 account abstraction #7311
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 4b2034f | Previous: 822f8c1 | Ratio |
---|---|---|---|
processingTx |
21438 ops/sec (±8.73% ) |
22958 ops/sec (±7.21% ) |
1.07 |
processingContractDeploy |
40479 ops/sec (±7.67% ) |
40077 ops/sec (±7.24% ) |
0.99 |
processingContractMethodSend |
16713 ops/sec (±7.43% ) |
15807 ops/sec (±8.02% ) |
0.95 |
processingContractMethodCall |
28021 ops/sec (±6.43% ) |
27362 ops/sec (±8.03% ) |
0.98 |
abiEncode |
44651 ops/sec (±8.01% ) |
44555 ops/sec (±6.70% ) |
1.00 |
abiDecode |
31358 ops/sec (±5.97% ) |
30694 ops/sec (±6.83% ) |
0.98 |
sign |
1530 ops/sec (±3.95% ) |
1590 ops/sec (±1.37% ) |
1.04 |
verify |
372 ops/sec (±0.48% ) |
365 ops/sec (±0.53% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7311 +/- ##
=======================================
Coverage 94.44% 94.45%
=======================================
Files 216 216
Lines 8463 8469 +6
Branches 2339 2341 +2
=======================================
+ Hits 7993 7999 +6
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
* ``` | ||
*/ | ||
|
||
public async getUserOperationByHash(hash: HexStringBytes) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is the first version, but it would be good to validate params before each request in the future. Also, it will be great to have a return format param and format the result for each request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added that in #7202 list
Description
#7202
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.