Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7202 account abstraction #7311

Merged
merged 15 commits into from
Oct 22, 2024
Merged

7202 account abstraction #7311

merged 15 commits into from
Oct 22, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 8, 2024

Description

#7202

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Oct 8, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.83 kB → 641.05 kB (+225 B) +0.03%
Changeset
File Δ Size
../web3-core/lib/commonjs/web3_config.js 📈 +497 B (+2.86%) 16.96 kB → 17.44 kB
../web3-eth/lib/commonjs/utils/send_tx_helper.js 📈 +61 B (+0.66%) 9.03 kB → 9.09 kB
../web3-eth/lib/commonjs/web3_eth.js 📈 +530 B (+0.57%) 90.77 kB → 91.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 621.34 kB → 621.56 kB (+225 B) +0.04%
../lib/commonjs/index.d.ts 8.69 kB → 8.72 kB (+35 B) +0.39%

Smaller

Asset File Size % Changed
../lib/commonjs/providers.exports.d.ts 183 B → 148 B (-35 B) -19.13%

Unchanged

Asset File Size % Changed
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4b2034f Previous: 822f8c1 Ratio
processingTx 21438 ops/sec (±8.73%) 22958 ops/sec (±7.21%) 1.07
processingContractDeploy 40479 ops/sec (±7.67%) 40077 ops/sec (±7.24%) 0.99
processingContractMethodSend 16713 ops/sec (±7.43%) 15807 ops/sec (±8.02%) 0.95
processingContractMethodCall 28021 ops/sec (±6.43%) 27362 ops/sec (±8.03%) 0.98
abiEncode 44651 ops/sec (±8.01%) 44555 ops/sec (±6.70%) 1.00
abiDecode 31358 ops/sec (±5.97%) 30694 ops/sec (±6.83%) 0.98
sign 1530 ops/sec (±3.95%) 1590 ops/sec (±1.37%) 1.04
verify 372 ops/sec (±0.48%) 365 ops/sec (±0.53%) 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (7c207b8) to head (4b2034f).
Report is 12 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7311   +/-   ##
=======================================
  Coverage   94.44%   94.45%           
=======================================
  Files         216      216           
  Lines        8463     8469    +6     
  Branches     2339     2341    +2     
=======================================
+ Hits         7993     7999    +6     
  Misses        470      470           
Flag Coverage Δ
UnitTests 94.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

* ```
*/

public async getUserOperationByHash(hash: HexStringBytes) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is the first version, but it would be good to validate params before each request in the future. Also, it will be great to have a return format param and format the result for each request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added that in #7202 list

@jdevcs jdevcs merged commit 331aa9c into 4.x Oct 22, 2024
54 checks passed
@jdevcs jdevcs deleted the junaid/7202accountabst branch October 22, 2024 08:03
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants