-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix types file #7331
fix types file #7331
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0bcc782 | Previous: 69187c5 | Ratio |
---|---|---|---|
processingTx |
22646 ops/sec (±8.45% ) |
21197 ops/sec (±9.42% ) |
0.94 |
processingContractDeploy |
41606 ops/sec (±7.01% ) |
39646 ops/sec (±7.16% ) |
0.95 |
processingContractMethodSend |
16942 ops/sec (±7.66% ) |
16345 ops/sec (±6.62% ) |
0.96 |
processingContractMethodCall |
27736 ops/sec (±8.08% ) |
27913 ops/sec (±6.12% ) |
1.01 |
abiEncode |
46781 ops/sec (±6.21% ) |
44153 ops/sec (±6.91% ) |
0.94 |
abiDecode |
31148 ops/sec (±7.26% ) |
30167 ops/sec (±8.30% ) |
0.97 |
sign |
1583 ops/sec (±0.73% ) |
1554 ops/sec (±3.55% ) |
0.98 |
verify |
369 ops/sec (±2.68% ) |
362 ops/sec (±0.54% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7331 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 216 216
Lines 8469 8469
Branches 2341 2341
=======================================
Hits 7999 7999
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
/** | ||
* Ignore gas price, turn on for metamask suggestion fee | ||
*/ | ||
ignoreGasPricing?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case some one is using this will be breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was from yesterdays merged pr, packages/web3-types/src/eth_contract_types.ts included by accident
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.