Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newPendingTransactionFilter #7353

Merged
merged 18 commits into from
Nov 5, 2024
Merged

newPendingTransactionFilter #7353

merged 18 commits into from
Nov 5, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Oct 24, 2024

Description

#7188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs changed the title Junaid/27188functionexport newPendingTransactionFilter Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 647 kB → 649.88 kB (+2.88 kB) +0.45%
Changeset
File Δ Size
../web3-eth/lib/commonjs/filtering_rpc_method_wrappers.js 🆕 +7.3 kB 0 B → 7.3 kB
../web3-eth/lib/commonjs/web3_eth.js 📈 +6.08 kB (+6.60%) 92.18 kB → 98.26 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 627.44 kB → 630.33 kB (+2.88 kB) +0.46%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.93 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0f6b7e2 Previous: 69d83e7 Ratio
processingTx 22604 ops/sec (±7.04%) 22353 ops/sec (±7.82%) 0.99
processingContractDeploy 40356 ops/sec (±6.61%) 37636 ops/sec (±7.55%) 0.93
processingContractMethodSend 16677 ops/sec (±7.31%) 15415 ops/sec (±6.99%) 0.92
processingContractMethodCall 27823 ops/sec (±8.03%) 28129 ops/sec (±6.61%) 1.01
abiEncode 45377 ops/sec (±7.67%) 42413 ops/sec (±7.80%) 0.93
abiDecode 30035 ops/sec (±7.81%) 30494 ops/sec (±7.44%) 1.02
sign 1495 ops/sec (±0.63%) 1487 ops/sec (±3.26%) 0.99
verify 351 ops/sec (±0.57%) 364 ops/sec (±0.46%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.51%. Comparing base (d446838) to head (06817cc).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7353      +/-   ##
==========================================
+ Coverage   94.50%   94.51%   +0.01%     
==========================================
  Files         217      218       +1     
  Lines        8495     8557      +62     
  Branches     2347     2363      +16     
==========================================
+ Hits         8028     8088      +60     
- Misses        467      469       +2     
Flag Coverage Δ
UnitTests 94.51% <96.77%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@danforbes danforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great documentation 🙏🏻 Just one question.

@jdevcs jdevcs merged commit 9fa32c9 into 4.x Nov 5, 2024
54 checks passed
@jdevcs jdevcs deleted the junaid/27188functionexport branch November 5, 2024 16:36
@luu-alex luu-alex mentioned this pull request Nov 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants