fix: CI workflow cache issues #7384
Conversation
krzysu
requested review from
avkos,
jdevcs,
luu-alex,
Muhammad-Altabba and
danforbes
as code owners
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7384 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 218 218
Lines 8557 8557
Branches 2363 2363
=======================================
Hits 8088 8088
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. |
krzysu
force-pushed
the
krzysu/fix-ci-cache
branch
from
2bca297 to
321aabf
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 20b7e1c | Previous: 2bca297 | Ratio |
|---|---|---|---|
processingTx |
20874 ops/sec (±8.31%) |
21322 ops/sec (±6.86%) |
1.02 |
processingContractDeploy |
38096 ops/sec (±6.73%) |
39487 ops/sec (±7.59%) |
1.04 |
processingContractMethodSend |
14621 ops/sec (±9.60%) |
16117 ops/sec (±8.11%) |
1.10 |
processingContractMethodCall |
25438 ops/sec (±9.42%) |
27148 ops/sec (±8.22%) |
1.07 |
abiEncode |
40101 ops/sec (±7.34%) |
43502 ops/sec (±6.33%) |
1.08 |
abiDecode |
29962 ops/sec (±6.55%) |
31073 ops/sec (±7.24%) |
1.04 |
sign |
1487 ops/sec (±3.70%) |
1531 ops/sec (±0.87%) |
1.03 |
verify |
361 ops/sec (±0.53%) |
360 ops/sec (±2.50%) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
.github/workflows/build.yml
Outdated
| packages/web3-utils/.eslintcache | ||
| packages/web3-validator/.eslintcache | ||
| tools/web3-plugin-example/.eslintcache | ||
| key: ${{ runner.os }}-eslintcache-${{ github.ref_name }} |
There was a problem hiding this comment.
use branch name in the cache key
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| - name: Save eslint caches | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/4.x' |
There was a problem hiding this comment.
After further consideration, I realized this cache setup is unnecessary since the cache is only being deleted and saved on the 4.x branch. By removing this extra logic, we allow actions/cache@v4 to manage the cache automatically—saving it when needed and restoring it if available. Please review the recent builds on this branch for reference.
There was a problem hiding this comment.
I finally understand what was happening here. The workflow was set up to store the lint cache for the 4.x branch and restore it for PR branches to lint only the diffs in a PR. The issue was that the 4.x cache didn’t exist, likely due to the cache reaching the 10GB limit, which resulted in older caches being deleted.
| @@ -42,7 +42,7 @@ import { ENSRegistryBytecode } from '../fixtures/ens/bytecode/ENSRegistryBytecod | |||
| import { NameWrapperBytecode } from '../fixtures/ens/bytecode/NameWrapperBytecode'; | |||
| import { PublicResolverBytecode } from '../fixtures/ens/bytecode/PublicResolverBytecode'; | |||
|
|
|||
| jest.setTimeout(25000); | |||
There was a problem hiding this comment.
these tests are failing regularly on the beforeAll step
Description
Trying to fix CI lint and benchmark workflows, because of failed cache delete, see ie. this build https://github.com/web3/web3.js/actions/runs/11814326177/job/32915706387
A lot of changes are because of prettier formatting the workflow file. You can disable whitespace changes to have better overview of the changes in this PR
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.