Tidy up QuorumTransactionManager to support chainId and madatoryFor #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonydenyer
force-pushed
the
master
branch
2 times, most recently
from
f53b084
to
447f752
Compare
Signed-off-by: Antony Denyer <git@antonydenyer.co.uk>
antonydenyer
changed the title
|
@AlexandrouR any chance you could take a look? |
|
Sure I will also ask @andrii-kl to have a look. |
AlexandrouR
reviewed
Jan 13, 2022
src/main/java/org/web3j/quorum/methods/request/PrivateRawTransaction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/web3j/quorum/methods/response/ContractPrivacyMetadataInfo.java
Outdated
Show resolved
Hide resolved
|
Looks great tests are passing i will make a PR later to remove Travis and add GitHub actions |
|
@AlexandrouR any ideas when this will be released? |
|
@antonydenyer a snapshot version was released for 4.8.9-SNAPSHOT but some of the integration tests are failing. I am looking at how I can automate the IT in GitHub actions using quorum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?