Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP1559 SUPPORT #38

Merged
merged 8 commits into from
Sep 1, 2021
Merged

EIP1559 SUPPORT #38

merged 8 commits into from
Sep 1, 2021

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Aug 15, 2021

EIP1559 SUPPORT #33

Change log:

  • Remove space from composer.json
  • Remove syntaxCheck from phpunit.xml
  • Update .gitignore
  • Add EIP2930 transaction
  • Add EIP1559 transaction
  • Refactor
  • Update document

- Remove space from composer.json
- Remove syntaxCheck from phpunit.xml
- Update .gitignore
@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #38 (b98241f) into master (7dd97d8) will decrease coverage by 18.36%.
The diff coverage is 57.73%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #38       +/-   ##
=============================================
- Coverage     88.97%   70.60%   -18.37%     
- Complexity       65      163       +98     
=============================================
  Files             1        4        +3     
  Lines           136      330      +194     
=============================================
+ Hits            121      233      +112     
- Misses           15       97       +82     
Impacted Files Coverage Δ
src/TypeTransaction.php 43.38% <43.38%> (ø)
src/EIP2930Transaction.php 90.47% <90.47%> (ø)
src/EIP1559Transaction.php 91.89% <91.89%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd97d8...b98241f. Read the comment docs.

@kaimuns950619
Copy link

Hi, may i know when this version will be release in order to Support EIP1559 transaction?

@sc0Vu
Copy link
Member Author

sc0Vu commented Aug 28, 2021

Hi @kaimuns950619

I traced web3.py and ethereumjs-tx source code and found that I missed these EIPs in current implementation:

  • EIP2718

  • EIP2930

  • EIP1559

I'm going to implement these EIPs before EIP1559. Guess I can finish in this week.

@sc0Vu
Copy link
Member Author

sc0Vu commented Aug 29, 2021

I've test type1 and type2 tx on rinkeby testnet, here is the transaction:

Type1: https://rinkeby.etherscan.io/tx/0xf47d05ded68391f95bc507d1e6808d8c41b730542791cea1fd76417689ef37a5

Type2: https://rinkeby.etherscan.io/tx/0x4c143d84c977dfc697482bacf980ec7807057866a9e11e9107b322a99356df9e

Also write web3.php in the transaction data, it was fun.

@sc0Vu sc0Vu changed the title [WIP] EIP1559 SUPPORT EIP1559 SUPPORT Aug 29, 2021
@kaimuns950619
Copy link

@sc0Vu Noted with thanks

@sc0Vu sc0Vu merged commit 8dc1adc into master Sep 1, 2021
@sc0Vu sc0Vu deleted the eip1559 branch September 1, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants