Split library into modules

[yaroslavyaroslav]

No description provided.

[JeneaVranceanu]

@yaroslavyaroslav I'll probably throw some additional comments into this PR. 🙂

[JeneaVranceanu]

That's a weird computed variable.
Is it correct that it always returns .POST?

[yaroslavyaroslav]

Actually yes, since none of Eth API uses any other REST method. But i'd either think that it's redundant, and could be just dropped in a favor of hardcoding this method in URLSession configuration.

[JeneaVranceanu]

I didn't want to leave more comments like this as there are a lot of ERC/EIP standards in the project.

We have two options here:

1. you can add appropriate links to the protocols in this PR;
2. we can open it as a separate issue for a later date as this is not something that must be fixed right now.

[yaroslavyaroslav]

@JeneaVranceanu thank you for your feedback, it's really helpful, i'll dig it deeply in few days ahead.

[yaroslavyaroslav]

I didn't want to leave more comments like this as there are a lot of ERC/EIP standards in the project.

We have two options here:

1. you can add appropriate links to the protocols in this PR;
2. we can open it as a separate issue for a later date as this is not something that must be fixed right now.

I'd prefer second one, because I'm planning to dedicate one or two last RC to improving documentation.

[JeneaVranceanu]

I'd prefer second one, because I'm planning to dedicate one or two last RC to improving documentation.

@yaroslavyaroslav

Opened an issue for documentation - #592
Please edit the items in the list as you see the need to and add more items if some are missing.

[yaroslavyaroslav]

@JeneaVranceanu please take a look at the PR updates that I've made up to your issues. All that've marked with thumb up emoji should be done. And if so mark them as resolved one please.

[JeneaVranceanu]

@JeneaVranceanu please take a look at the PR updates that I've made up to your issues. All that've marked with thumb up emoji should be done. And if so mark them as resolved one please.

Great! Thanks for taking time to update things.
I cannot resolve these comments as I do not have rights but at this point in time I've no additional comments and all of the comments above with a 👍 can indeed be marked as resolved. If you have that permission feel free to do so.
For me there is simply no such button 🙂