fix: data field in CodableTransaction must be passed into the envelope #624
Conversation
JeneaVranceanu
changed the title
| @@ -420,8 +416,6 @@ extension CodableTransaction { | |||
| chainID: BigUInt = 0, value: BigUInt = 0, data: Data = Data(), | |||
| gasLimit: BigUInt = 0, maxFeePerGas: BigUInt? = nil, maxPriorityFeePerGas: BigUInt? = nil, gasPrice: BigUInt? = nil, | |||
| accessList: [AccessListEntry]? = nil, v: BigUInt = 1, r: BigUInt = 0, s: BigUInt = 0) { | |||
| // FIXME: This is duplication and should be fixed. | |||
| self.data = data | |||
| self.accessList = accessList | |||
There was a problem hiding this comment.
I know this is WIP but commenting what I see just to make sure. I guess accessList can be removed as well here.
There was a problem hiding this comment.
Also the comments of the function could be cleaned up. As most params are optional but a lot of them still read as (required)
There was a problem hiding this comment.
Thanks for the input.
Next week I'll come back to this PR and will thoroughly check everything you've suggested.
There was a problem hiding this comment.
Done. Sorry for delay.
A new EIP2930Compatible protocol was introduced to support kind of easy access to accessList.
|
Hi, Is it still testing? When it will be merged to develop? I have a problem with sending parameters to contract methods. |
|
@salihcnkhy yep, it still is. About ETA we probably better to ask @JeneaVranceanu, is there much to do here yet? |
|
@salihcnkhy @yaroslavyaroslav Hello there. |
|
@JeneaVranceanu Okay thanks a lot. |
JeneaVranceanu
changed the title
|
@salihcnkhy @yaroslavyaroslav Sorry for delays. Now, this PR is up to date. |
Potential fix for #619
Still testing.