Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Issues template forms #652

Merged
merged 1 commit into from
Nov 3, 2022
Merged

feat: Add Issues template forms #652

merged 1 commit into from
Nov 3, 2022

Conversation

Vinitvh
Copy link
Contributor

@Vinitvh Vinitvh commented Nov 3, 2022

Added Issue templates for:

  • Bug report
  • Documentation
  • Feature request

Closes #643

Copy link
Collaborator

@yaroslavyaroslav yaroslavyaroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, since this doesn't affects the code in any way, I'll merge it out of turn.

@yaroslavyaroslav
Copy link
Collaborator

But please change the base branch to the master.

@Vinitvh
Copy link
Contributor Author

Vinitvh commented Nov 3, 2022

I don't think I can do that as I have forked develop branch, or Is there something I'm missing here?

@yaroslavyaroslav
Copy link
Collaborator

You're forking a whole repo, not a given branch, but anyway there's a drop-down menu should be available to you on a place where base branch shown. Maybe it's required to press edit btn or something.

Just to clarify it a bit: you for sure have an option to change base branch within any of your PR, it could leads to an merge problems or some another issues, but that's different. Not in this case though.

@Vinitvh Vinitvh changed the base branch from develop to master November 3, 2022 17:04
@Vinitvh
Copy link
Contributor Author

Vinitvh commented Nov 3, 2022

Done. Thank you.

@yaroslavyaroslav yaroslavyaroslav merged commit 6eebef7 into web3swift-team:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues template forms
2 participants